Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Run cve checks workflow on pull requests and pushes to main #745

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Infra: Run cve checks workflow on pull requests and pushes to main #745

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e791e3
Infra: Run cve checks workflow on pull requests and pushes to main
yeikel Jan 3, 2025
d5a52d3
only send from main
yeikel Jan 3, 2025
ce6cbce
Merge branch 'main' into issue/707
yeikel Jan 6, 2025
94da91b
run only on scheduled executions
yeikel Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/cve_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: "Infra: CVE checks"
on:
pull_request_target:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need pull_request_target for this particular workflow, pull_request should suffice.

push:
branches: [ "main" ]
workflow_dispatch:
schedule:
# * is a special character in YAML so you have to quote this string
Expand Down Expand Up @@ -71,7 +74,7 @@ jobs:

notify:
needs: build-and-test
if: ${{ always() && needs.build-and-test.result == 'failure' }}
if: ${{ always() && needs.build-and-test.result == 'failure' && github.ref == 'refs/heads/main' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please adjust this so it only runs upon failures of scheduled runs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated it

94da91b

I removed the branch check because scheduled runs only happen from the main branch

uses: ./.github/workflows/infra_discord_hook.yml
with:
message: "Attention! CVE checks run failed! Please fix them CVEs :("
Expand Down
Loading