-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize job cluster role and image #214
Parametrize job cluster role and image #214
Conversation
82435aa
to
fb310df
Compare
How to solve the reported problems that are not the result of my changes?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A couple nits but overall looks good.
ab2c47b
to
e9b04c8
Compare
e9b04c8
to
1fea2d6
Compare
Signed-off-by: Piotr Minkina <[email protected]>
Signed-off-by: Piotr Minkina <[email protected]>
Signed-off-by: Piotr Minkina <[email protected]>
…aging helm charts Signed-off-by: Piotr Minkina <[email protected]>
…elm charts Signed-off-by: Piotr Minkina <[email protected]>
1fea2d6
to
e1c93f5
Compare
LGTM, but tests appear to be failing due to the linter complaining about dot imports of the test DSL... if you want to take a shot at fixing that go for it, otherwise I'll fix it in another PR and you can rebase. |
Signed-off-by: Piotr Minkina <[email protected]>
80068ea
to
5c32c60
Compare
@brandond I added an exclusion rule, exactly as they did in Istio: https://github.com/istio/client-go/blob/46ba363b2dc16d8cd575f17de240ca840db2f7cf/common/config/.golangci.yml#L259 |
@brandond I can't merge. Will You plan? |
Mainly implements #213 and additionally allows also specyfiying Cluster Role to be used with job images. These are changes that are needed in a hermetic, corporate environment with no direct access to the Internet and a zero-trust policy. I also made other improvements that I felt were appropriate, as a fresh person joining the project.
Constructive comments welcome — I'm a Golang newbie, albeit with a non-short programming experience.