Fix keyword spotting. #1689
Open
Fix keyword spotting. #1689
+40
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also k2-fsa#1417
|
also， fixes #1235 @carcloudfly @yuyun2000 |
|
This is cool, we recently discovered the blank parameter issue, but haven’t confirmed it yet. |
|
cool! please supplement the API for JNI / Java / Kotlin. thanks. |
brekov
added a commit
to brekov/sherpa-onnx
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1417
Fixes #1417
CC @codepubs @brekov
I think there is a bug in keyword spotting.
After the keyword is detected, the result.num_trailing_blanks of subsequent calls with
Decode()is always 0.This PR resets the stream after detecting a keyword to avoid that (Users should call it manually).
Also, it resets the stream automatically after detecting 1.5 seconds of silence.