This repository has been archived by the owner on Feb 11, 2023. It is now read-only.
Code Review #1
Open
Code Review #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not perfect but it helps make things a bit more rustic.
Rust is pretty good at this and will tell you when it can't do it for you.
It's more idiomatic (slices are built into the language itself).
First `a == b` desugars to `PartialEq::eq(&a, &b)`. Second, `&a` autoderefs as needed to get the right type (it first tries `&a`, then `&*a`, then `&**a` etc.).
Unlike languages like Java, rust can infer your types and will do so as long as they don't appear in signatures. You can state them explicitly but it usually adds more noise than it's worth.
When you actually want to display strings, there's no point in using the debug formatter. Also, I figured I show of a cool use of match :).
Otherwise, they can make breaking changes and break your program. This is less of an issue with binary packages because you check in Cargo.lock but is still a good idea. The rule is: If the library is version 0.0.z, use 0.0.z (the full version). If the library is version 0.y.z, use 0.y (allow patch releases). If the library is version x.y.z, use x (no breaking changes) or x.y (no new features).
|
Github isn't the best way to look at these. I recommend |
|
Hi Stebalien! Thanks a lot for this pull request - I am very impressed by your propositions! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed your program as a series of commits (comments in the commit
messages). Feel free to discard this PR when you've read them (or merge it if you want but that's obviously up to you).