Introduce ConversionSupport in junit-platform-commons
#3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
juliette-derancourt
force-pushed
the
issues/3449-string-conversion-support
branch
from
a6d2951 to
e2d664c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
6 tasks
juliette-derancourt
force-pushed
the
issues/3449-string-conversion-support
branch
from
d763897 to
8303181
Compare
juliette-derancourt
force-pushed
the
issues/3449-string-conversion-support
branch
from
2ea517d to
3c47bed
Compare
sbrannen
approved these changes
Nov 21, 2023
juliette-derancourt
deleted the
issues/3449-string-conversion-support
branch
sbrannen
added a commit
that referenced
this pull request
Dec 15, 2023
This commit picks up where commit 30dbf58 left off. Specifically, this commit removes all obsolete StringToObjectConverter implementations from junit-jupiter-params since they now reside in junit-platform-commons. In addition, this commit moves FallbackStringToObjectConverterTests to the platform-tests module. See #3507
sbrannen
changed the title
StringConversionSupport in junit-platform-commonsConversionSupport in junit-platform-commons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
ConversionSupportinjunit-platform-commons#3449I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations