utopia-gen: Adjust params code to not set nullable
on Option
for Query
params
#1248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1215 by ensuring that
Option<_>
usage inQuery
params is not transformed into a nullable feature.https://swagger.io/docs/specification/v3_0/describing-parameters/#default-parameter-values gives an example on how
required: false
query parameters are described and there is nonullable: true
orschema.type: null
in there, which indicates thatrequired: false
should be sufficient to describe anOption<_>
type for query parameters.(Potentially) Related:
Option
non-required & addrequired
attr #530