Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transloco): complete subjects when root view is removed #822

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix(transloco): complete subjects when root view is removed #822

merged 1 commit into from
Jan 2, 2025

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Jan 1, 2025

No description provided.

shaharkazaz
shaharkazaz reviewed Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@shaharkazaz shaharkazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🥳

libs/transloco/src/lib/transloco.service.ts Show resolved Hide resolved
libs/transloco/src/lib/transloco.service.ts Show resolved Hide resolved
@arturovt arturovt force-pushed the fix/complete-when-destroyed branch from 4d3a01e to 5e2f378 Compare January 2, 2025 08:54
@arturovt
Copy link
Contributor Author

arturovt commented Jan 2, 2025

I replaced ngOnDestroy with DestroyRef to remove the redundant method.

shaharkazaz
shaharkazaz approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@shaharkazaz shaharkazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shaharkazaz shaharkazaz merged commit 0b3fa79 into jsverse:master Jan 2, 2025
6 checks passed
@arturovt arturovt deleted the fix/complete-when-destroyed branch January 2, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharkazaz shaharkazaz shaharkazaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturovt @shaharkazaz