-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[panda_eus] Skip generating dual_panda.l when franka_description or xacro is old to avoid build failure #1751
Conversation
…ld to avoid build failure
can you add the version information in 👀
|
From my point of view, writing version to both CMakeLists.txt and package.xml seems not easy to maintenance, because these versions should be synchronized. |
what i want to do is avoiding the build failure. |
Then, this PR is OK, I think. |
Previously, I thought using melodic and upper is enough because I assumed all packages are up to date
Another solution of #1749
Currently, buildingpanda_eus
fails whenfranka_description
's version is less than 0.10.0.Currently, building
panda_eus
fails whenfranka_description
's version is less than 0.10.0 orxacro
's version is less than 1.13.14.This PR fixes it by skipping
dual_panda.l
generation.