Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panda_eus] Skip generating dual_panda.l when franka_description or xacro is old to avoid build failure #1751

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

pazeshun
Copy link
Contributor

@pazeshun pazeshun commented Dec 4, 2022

Another solution of #1749
Currently, building panda_eus fails when franka_description's version is less than 0.10.0.
Currently, building panda_eus fails when franka_description's version is less than 0.10.0 or xacro's version is less than 1.13.14.
This PR fixes it by skipping dual_panda.l generation.

@knorth55
Copy link
Member

knorth55 commented Dec 6, 2022

can you add the version information in package.xml like this?
this changes nothing now, but it may change the behavior in the future.

👀
ros-infrastructure/rosdep#694

 <build_depend version_gte="0.7.11">fetch_teleop</build_depend> 

@pazeshun
Copy link
Contributor Author

pazeshun commented Dec 6, 2022

From my point of view, writing version to both CMakeLists.txt and package.xml seems not easy to maintenance, because these versions should be synchronized.
We can leave comments, but they may be ignored.
Also, the future version_gte may cause build failure
when the version is not met.
What you want to accomplish with #1749 is not to cause build failure, isn't it?

@knorth55
Copy link
Member

knorth55 commented Dec 6, 2022

what i want to do is avoiding the build failure.
but imo, it is not hard to maintain both, but it depend on your decision.

@pazeshun
Copy link
Contributor Author

pazeshun commented Dec 6, 2022

Then, this PR is OK, I think.

@knorth55
Copy link
Member

knorth55 commented Dec 6, 2022

@pazeshun can you also check #1758 , too?

Previously, I thought using melodic and upper is enough because I assumed all packages are up to date
@pazeshun pazeshun changed the title [panda_eus] Skip generating dual_panda.l when franka_description is old to avoid build failure [panda_eus] Skip generating dual_panda.l when xacro or franka_description is old to avoid build failure Dec 6, 2022
@pazeshun pazeshun changed the title [panda_eus] Skip generating dual_panda.l when xacro or franka_description is old to avoid build failure [panda_eus] Skip generating dual_panda.l when franka_description or xacro is old to avoid build failure Dec 6, 2022
@pazeshun
Copy link
Contributor Author

pazeshun commented Dec 6, 2022

@pazeshun can you also check #1758 , too?

Maybe that issue was fixed by the latest commit.
Please check it.

@k-okada k-okada merged commit 308d340 into jsk-ros-pkg:master Dec 13, 2022
@pazeshun pazeshun deleted the check-franka-ver branch December 13, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
panda dual franka robot in JSK WaitForReview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants