Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: break non live-share circular dependencies #548

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

talohana
Copy link

I'm trying to import this extension and use it in Google, however our TS rules doesn't allow circular dependencies.

Live-share related imports are not needed, hence not resolved.

Output of npx madge --exclude='live-share' --circular --extensions ts ./:

⠋ Finding files=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0

YOUR TYPESCRIPT VERSION: 5.4.5

Please only submit bug reports when using the officially supported version.

=============
Processed 53 files (3.4s) 

✔ No circular dependency found!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant