Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser checks that are no longer applicable. #605

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove browser checks that are no longer applicable. #605

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b42ff2
Remove browser checks that are no longer applicable.
jallamsetty1 Jun 20, 2023
7a096d0
Enable test - muteAfterJoinCanShareAndUnmute and remove firefox check.
jallamsetty1 Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/test/java/org/jitsi/meet/test/AvatarTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,6 @@ public void avatarWhenVideoMuted()
@Test(dependsOnMethods = { "avatarWhenVideoMuted" })
public void testEmailPersistence()
{
// This test is very often failing on FF (due to a crash on hangup
// present in FF57)
// will disable it for now
if (getParticipant1().getType().isFirefox())
{
return;
}

getParticipant1().getToolbar().clickProfileButton();

String currentEmailValue
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/jitsi/meet/test/MuteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ private void muteParticipant1BeforeParticipant2JoinsAndScreenshare(String enable
WebParticipant participant1 = getParticipant1();

// Skip the test in p2p mode for Firefox since p2p is disabled in code for Firefox.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But let's remove and the comment :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I thought I removed the comment as well.

if (!participant1.getType().isFirefox() || enableP2p.equals("false"))
if (enableP2p.equals("false"))
{
WebParticipant participant2 = joinSecondParticipant(url2);
participant2.waitToJoinMUC();
Expand Down
11 changes: 0 additions & 11 deletions src/test/java/org/jitsi/meet/test/StartMutedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,17 +177,6 @@ public void startWithVideoMutedCanUnmute()
ParticipantType participant1Type = participant1.getType();
ParticipantType participant2Type = participant2.getType();


// Firefox is known to have problems unmuting when starting muted.
// Safari does not support video.
if (participant1Type.isFirefox()
|| participant2Type.isFirefox()
|| participant1Type.isSafari()
|| participant2Type.isSafari())
{
return;
}

hangUpAllParticipants();

// Explicitly enable P2P due to a regression with unmute not updating
Expand Down