Code formatting and documentation #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used cargo fmt with default settings, as it's good quality and pretty standard. That should make code easier to read, and more uniform. This also adds some consistency on EOF newlines. I manually reviewed all changes.
|
I think that's about all i can clean up and document. |
src/ignore/git.rs
Outdated
| assert_eq!(filter.only_dir, true); | ||
| assert_eq!(filter.negate, false); | ||
| assert!(filter.only_dir); | ||
| assert!(filter.negate); |
There was a problem hiding this comment.
Looks like this assertion is the opposite from the original one. Haven't that affected the tests at all?
There was a problem hiding this comment.
It sure did. I ran cargo test on linux, so i didn't catch that since it's a windows test 😓
I was waiting to see the workflow results for the windows tests to see if i hadn't screwed anything up there
|
Hooray! Great job, really! Thank you so much. Merged with a deep feeling of satisfaction :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the code easier to work on by formatting the code with
cargo fmt, refactoring and cleaning up some of the code, and adding comments to document the code.For the formatting, i manually went through and verified every change.
I kept the formatting commit separate on purpose, so if you don't like it i can rebase the PR without them.