Don't leak App in unit tests as clang-tidy complains

jhasse · Oct 27, 2024 · 98d6e82 · 98d6e82
1 parent 8967e20
commit 98d6e82
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/App.cpp b/src/App.cpp
@@ -46,7 +46,8 @@ App::~App() {
 
 App& App::instance() {
 	if (!self) {
-		self = new App;
+		static App dummy; // e.g. for unit tests
+		self = &dummy;
 	}
 	return *self;
 }

diff --git a/src/jngl/Mat3.cpp b/src/jngl/Mat3.cpp
@@ -1,4 +1,4 @@
-// Copyright 2021-2023 Jan Niklas Hasse <[email protected]>
+// Copyright 2021-2024 Jan Niklas Hasse <[email protected]>
 // For conditions of distribution and use, see copyright notice in LICENSE.txt
 #include "Mat3.hpp"
 
@@ -26,8 +26,8 @@ Mat3& Mat3::translate(const jngl::Vec2& v) {
 }
 
 Mat3& Mat3::translate(const Pixels x, const Pixels y) {
-	return *this *=
-	       boost::qvm::translation_mat(boost::qvm::vec<double, 2>{ { float(x), float(y) } });
+	return *this *= boost::qvm::translation_mat(
+	           boost::qvm::vec<double, 2>{ { static_cast<float>(x), static_cast<float>(y) } });
 }
 
 Mat3& Mat3::scale(const float factor) {