Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Fix DotNet installing on Ubuntu #2808

Merged
merged 29 commits into from
Dec 30, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Dec 30, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

It seems there is an issue with the setup-dotnet action on Ubuntu regarding the installation path and permissions.

  1. Inconsistent installation path: [Issue #554](Looks like when setup-dotnet is used, then the install path is different from the hosted images actions/setup-dotnet#554)
  2. Insufficient permissions: [Issue #565](mkdir: cannot create directory ‘/usr/share/dotnet’: Permission denied actions/setup-dotnet#565)

Until these issues are consistently resolved, this PR manually sets the installation directory and adjusts its permissions to prevent crashes during installation.

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Dec 30, 2024
@EyalDelarea EyalDelarea changed the base branch from v2 to dev December 30, 2024 09:25
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review December 30, 2024 12:00
@EyalDelarea EyalDelarea merged commit dea84f2 into jfrog:dev Dec 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants