[Jenkins-52906] add support for jcasc

[jetersen]

JENKINS-52906
jenkinsci/configuration-as-code-plugin#809

• Convert global configuration to an actual Global Configuration extension
• Populate jira sites from folders in Job configuration.
• Make URL the only mandatory field and simplify constructor. See Simplify constructor, main URL is the only mandatory field #173
• Use List's instead of Array's, when possible
• Use numbers in jira site's jelly. See use numbers on jira site jelly #172
• Fix tests:
  • Add jcasc test.
  • Convert jira folder property test to use round trip test, caught a few mistakes in jira site setters.
  • faster travis build & Use enable Jacoco flag. See speed up travis and use enable-jacoco profile #171

This is easier to shown in UI, we now support folder in folder lookup of Jira Site 🙌

Hmm wonder if it would be better to sort the list 😅

Nice jcasc doc:

Nice jcasc export:

plugins:
  sites:
  - id: "default"
    url: "http://updates.jenkins-ci.org/update-center.json"
jenkins:
  agentProtocols:
  - "CLI-connect"
  - "CLI2-connect"
  - "JNLP-connect"
  - "JNLP2-connect"
  - "JNLP4-connect"
  - "Ping"
  disableRememberMe: false
  mode: NORMAL
  numExecutors: 2
  primaryView:
    all:
      name: "all"
  quietPeriod: 5
  scmCheckoutRetryCount: 0
  slaveAgentPort: 0
  views:
  - all:
      name: "all"
unclassified:
  jiraglobalconfiguration:
    sites:
    - url: "https://issues.jenkins-ci.org/"
    - url: "https://backwardsCompatURL.com/"
tool:
  jdk:
    defaultProperties:
    - installSource:
        installers:
        - jdkInstaller:
            acceptLicense: false

[coveralls]

Coverage increased (+1.0%) to 55.913% when pulling e58465f on casz:JENKINS-52906 into 7813dd7 on jenkinsci:master.

[jetersen]

Writing more tests to fix coverage 😅😤😇

[artkoshelev]

I can't put my review comments for some reason, got that error

Unchecked runtime.lastError while running storage.set: QUOTA_BYTES_PER_ITEM quota exceeded

[jetersen]

@artkoshelev github had a datastore issue: https://status.github.com
Could you cleanup your test comments 😅
I'll look into review

[artkoshelev]

yeah, took me a while to figure out it's on github side not mine =)

[jetersen]

This is where I can sit cry in a corner, rewriting tests to please reviewers 😅 No, I would rather rebase after merge of another PR and link to the commit view that pleases the reviewer.

[jetersen]

This is the compare window your looking for: https://github.com/casz/jira-plugin/compare/simpleConstructor...casz:JENKINS-52906

[ewelinawilkosz]

great job with this fix, where do we stand though? were the comments addressed?

[jetersen]

No, haven't had time and seems like the PRs are blocked by stats padding the coverage if the comments were to be addressed.

[kmcquade]

@Casz @ewelinawilkosz @olamy @artkoshelev - any updates? We really need this. Thanks

[timja]

@kmcquade Parts of this PR have been extracted to others see the heading,
Currently the outstanding one is: #177
Once that's been merged this one probably needs a little cleanup, hopefully its not far off though

[jetersen]

if #177 can get merged I will rework this PR 😄

[jetersen]

Please take another look 😄

[jetersen]

I will fix the compilation error later — followed @artkoshelev review comment to remove test in front of the name.

[jetersen]

@olamy @artkoshelev I should have addressed all your concerns.

[jetersen]

Conflict resolved

[jetersen]

@olamy @artkoshelev what are the chances of this getting merged?

[artkoshelev]

It looks good to me, but change is pretty big, did you performed any kind of manual/integration testing?

[jetersen]

I don't actively use Jira. I am just here fixing the JCasC support plus some more while I was at it.

perhaps @kmcquade or @timja can 😅 You should able to grab the HPI here: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/jira/3.0.7-rc971.e58465f3b1cd/

I wouldn't agree with big changes, most of it is done in testing. Very little is changed in the actual code besides some Java 8 cleanup.

[jetersen]

Removing all the test addition and import changes I am left with the significant change which are 152 additions and 99 deletions. So how big was this change?

[jetersen]

I did do some testing. Tested that configuration would be transferred to the new JiraGlobalConfiguration and tested that nested folder sites would show up. Did you not see the screenshots in the PR description?
Besides that everything else should continue to work.

[jetersen]

@olamy Would be good to get this in :)

[jetersen]

@olamy @artkoshelev users are asking for the jcasc support in our gitter channel