Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make https default for plugin downloads #265

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Make https default for plugin downloads #265

merged 2 commits into from
Oct 9, 2020

Conversation

sladyn98
Copy link

@sladyn98 sladyn98 commented Apr 5, 2020

This PR aims to make https default for downloading plugins.
Closes: #258

@sladyn98
Copy link
Author

sladyn98 commented Apr 5, 2020

The mirrors still do not support https so I am unsure if it does not find would it default to http
CC @oleg-nenashev @LinuxSuRen

@LinuxSuRen
Copy link
Member

I guess we still need to wait until HTTPS is ok.

@oleg-nenashev oleg-nenashev self-requested a review April 5, 2020 20:14
@oleg-nenashev
Copy link
Member

Yes, I suggest putting it on hold until the new Mirror infra is rolled out. CC @olblak
FTR https://issues.jenkins-ci.org/browse/INFRA-2516

@rsvoboda
Copy link
Collaborator

rsvoboda commented Oct 8, 2020

@oleg-nenashev / @sladyn98 I think this can be rebased and on-hold label removed, INFRA-2516 is resolved

@oleg-nenashev
Copy link
Member

Agreed @rsvoboda

@oleg-nenashev oleg-nenashev requested a review from a team as a code owner October 8, 2020 19:59
@oleg-nenashev oleg-nenashev added enhancement New feature or request squash-merge-me and removed on-hold labels Oct 8, 2020
@oleg-nenashev
Copy link
Member

It worth mentioning that this code will be removed once Plugin Installation Manager Tool is integrated in #324. I am not a big fan of using on-demand plugin download even with that tool, in the most of cases it is better package plugins in the Build Time while packaging custom JFR images. Good for some demos though

olblak
olblak approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/ No more HTTP

oleg-nenashev
oleg-nenashev approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine (c). I added test coverage in #391 , but this is not a right time to spend too much time on tests for this feature. Tests will be a must when integrating Plugin Installation Manager

@oleg-nenashev oleg-nenashev merged commit 576d12f into jenkinsci:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@olblak olblak olblak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request squash-merge-me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use HTTPs by default for plugin downloads
5 participants
@sladyn98 @LinuxSuRen @oleg-nenashev @rsvoboda @olblak