Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Console Output on the build page (behind an experimental flag) #10115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jan 4, 2025

This PR adds the Console Output to the build page (behind an experimental flag). This reduces the amount of clicks it takes to get to the console, making it easy to see build output.

The implementation allows for console providers (such as Pipeline Graph View) to override what displays on the build page.

Why the flag? Modifying the build pages is pretty fiddly due to the sidebar and summary items, so I've put this behind a flag to not disrupt existing users layouts unless they explicitly want to. Keen to make more use of flags going forward to avoid disruption/allow for more iterative work on things like this.

Freestyle
image

Pipeline
image

Flag
image

Testing done

  • Widget hides if the flag is disabled
  • Widget shows if the flag is enabled
  • Existing console works as expected

Proposed changelog entries

  • Add the option to display the Console Output on the build page (behind an experimental flag)

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 4, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timja
Copy link
Member

timja commented Jan 4, 2025

I'm getting this:

image

@timja
Copy link
Member

timja commented Jan 4, 2025

I don't have pipeline graph view installed on this instance or any other console provider

@janfaracik
Copy link
Contributor Author

janfaracik commented Jan 5, 2025

I don't have pipeline graph view installed on this instance or any other console provider

Ah great spot, hadn't considered that that prop could be null. Defaults to the DefaultConsoleProvider now 👍

@krisstern krisstern requested a review from timja January 5, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants