Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS - 73837] Changing DirScanner to allow empty directories in TARArchiver #10114

Conversation

PalashChitnavis
Copy link

Regarding JENKINS - 73837

Testing done
image

Changes

  1. Changed DirScanner to accommodate empty directories as they weren't being passed to visit() function in TarArchiver
  2. Changed VirtualFile so that it adds empty directories to vf object while testing
  3. Made changes to tests which uses the DirScanner object.

Copy link

welcome bot commented Jan 4, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@mawinter69
Copy link
Contributor

duplicates #9836

@PalashChitnavis
Copy link
Author

@mawinter69 is this issue still open or the changes in #9836 close this ?

@mawinter69
Copy link
Contributor

The mentioned PR is trying to fix the same issue and is still work in progress. I would be in favor to close this one here to avoid that the same discussion is repeated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants