Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting API documentation of builds vs. allBuilds #10112

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 2, 2025

See #1817 (comment).

Testing done

@Exported(name = "builds")
public RunList<RunT> getNewBuilds() {
return getBuilds().limit(100);
}
remains the current value. Not tested other than that.

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Desired reviewers

@daniel-beck

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daniel-beck daniel-beck added the skip-changelog Should not be shown in the changelog label Jan 3, 2025
@daniel-beck daniel-beck merged commit d3e8908 into jenkinsci:master Jan 3, 2025
15 checks passed
@jglick jglick deleted the allBuilds branch January 3, 2025 15:01
janfaracik added a commit to janfaracik/jenkins that referenced this pull request Jan 5, 2025
commit 76d4bb8
Author: Jan Faracik <[email protected]>
Date:   Sun Jan 5 11:01:47 2025 +0000

    Fix in case of null provider

commit ebb6831
Author: Jan Faracik <[email protected]>
Date:   Sat Jan 4 15:23:03 2025 +0000

    Lint

commit 11e4b8d
Author: Jan Faracik <[email protected]>
Date:   Sat Jan 4 14:48:20 2025 +0000

    Init

commit 519eb19
Merge: 908030e b3b5a69
Author: Kris Stern <[email protected]>
Date:   Sat Jan 4 16:01:19 2025 +0800

    Merge pull request jenkinsci#9980 from basil/OptionHandlerExtension

    Register `OptionHandler`s through `META-INF/services/annotations` and Annotation Indexer rather than `META-INF/services` and Commons Discovery

commit 908030e
Merge: d3e8908 fc4a567
Author: Kris Stern <[email protected]>
Date:   Sat Jan 4 16:00:31 2025 +0800

    Merge pull request jenkinsci#10026 from mtughan/allow-immutable-collections

    Allow all immutable List subclasses from Java 11

commit d3e8908
Author: Jesse Glick <[email protected]>
Date:   Fri Jan 3 05:43:27 2025 -0500

    Correcting API documentation of `builds` vs. `allBuilds` (jenkinsci#10112)

commit 89f48c5
Merge: 238c498 e1dff1a
Author: Kris Stern <[email protected]>
Date:   Fri Jan 3 18:00:18 2025 +0800

    Merge pull request jenkinsci#10106 from timja/ballColorTd-table

    [JENKINS-74868] Use new build status symbols in multi branch projects

commit 238c498
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jan 2 20:32:04 2025 -0800

    Update dependency io.jenkins.plugins:design-library to v342 (jenkinsci#10111)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 75410bc
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jan 2 10:45:55 2025 -0800

    Update dependency io.jenkins.plugins:json-api to v20241224 (jenkinsci#10110)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 1aa9c57
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jan 2 10:44:50 2025 -0800

    Update Yarn to v4.6.0 (jenkinsci#10109)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit e1dff1a
Author: Tim Jacomb <[email protected]>
Date:   Tue Dec 31 19:46:12 2024 +0000

    Adjust test

commit 5fd9f51
Author: Tim Jacomb <[email protected]>
Date:   Mon Dec 30 22:20:15 2024 +0000

    [JENKINS-74868] Use new build status symbols in multi branch projects

commit b3b5a69
Merge: 33d8280 d73c0ea
Author: Basil Crow <[email protected]>
Date:   Tue Dec 17 10:19:22 2024 -1000

    Merge branch 'master' into OptionHandlerExtension

commit fc4a567
Author: Michael Tughan <[email protected]>
Date:   Wed Dec 4 15:15:13 2024 -0500

    Allow all immutable List subclasses from Java 11

    A previous commit specifically allowed one of the two subclasses used by
    `List.of` and `List.copyOf`, but not the other, which can result in
    unexpected errors and bugs. Add the other to the default allow list of
    classes to avoid these.

commit 33d8280
Merge: a1c8c83 9965f04
Author: Tim Jacomb <[email protected]>
Date:   Sun Dec 8 08:32:24 2024 +0000

    Merge branch 'master' into OptionHandlerExtension

commit a1c8c83
Author: Basil Crow <[email protected]>
Date:   Fri Nov 15 10:58:26 2024 -0800

    Register `OptionHandler`s through `META-INF/services/annotations` and Annotation Indexer rather than `META-INF/services` and Commons Discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants