-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"slave" terminology was deprecated in Jenkins 2.0 and was hence replaced with "agent" Issue - JENKINS-42816. #10108
Conversation
…d with agent Issue - JENKINS-42816.
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the newbie-friendly
label from that epic because there is a tendency for new contributors to not read the entire description of the issue.
This pull request proposes breaking changes with no attempt at compatibility. That's contrary to Jenkins project governance document where we have a section "Compatibility Matters" that describes how important compatibility is to Jenkins users.
if you'd like to help make progress on the deprecation of the "slave" term, you're encouraged to do so, but it needs to be done in a way that preserves compatibility. Smaller pull requests that change a specific detail are more likely to be considered and more likely to make progress than a pull request that changes over 800 files, does not compile, and does not pass automated tests.
I'm closing this pull request. You're welcome to submit additional pull requests, but a pull request of this size and this impact is unlikely to be accepted from a new contributor. |
Understood sir, Thank you for the response. Thank you for your patience. |
Thanks for the comment. I think that you're referring to the "scope" heading in the JENKINS_42816 epic description. That text is specific to that epic, not a general pattern that applies to all issues. I think that it is reasonable to expect new contributors to read the entire description of an issue before they contribute to the issue. Most open source communication is asynchronous. It depends on each of us to read what is written and to use what we learn from the written information. There are many times when I need to read the issue description multiple times to assure that I understand it. I don't think that moving the "scope" heading and its text to the top would reduce the need to read the entire description |
Yes sir, Understood. |
yes sir, it is. |
No problem at all. Thanks for contributing to open source software and thanks especially for contributing to Jenkins. We're learning together and that is good for all of us. |
See JENKINS-42816.
As a beginner i request you to kindly review my work and provide suggestions on how to move forward.
Testing done
Result was given as :
When i went to the documentation page to get the details of the error, It was said to be an issue with a plugin rather than of the jenkins core.
If this is wrong or it requires some further intervention please let me know.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist