Merge pull request #10089 from jglick/headerCommandPaletteButton

`headerCommandPaletteButton` undefined when `JenkinsHeader` not loaded
jenkinsci · Dec 22, 2024 · f643db8 · f643db8
2 parents a788745 + dae326c
commit f643db8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/main/js/components/command-palette/index.js b/src/main/js/components/command-palette/index.js
@@ -13,6 +13,9 @@ function init() {
   const headerCommandPaletteButton = document.getElementById(
     "button-open-command-palette",
   );
+  if (headerCommandPaletteButton === null) {
+    return; // no JenkinsHeader, no h:searchbox
+  }
   const commandPalette = document.getElementById("command-palette");
   const commandPaletteWrapper = commandPalette.querySelector(
     ".jenkins-command-palette__wrapper",

diff --git a/test/src/test/java/lib/layout/LayoutTest.java b/test/src/test/java/lib/layout/LayoutTest.java
@@ -53,4 +53,9 @@ public class LayoutTest {
         }
     }
 
+    @Test public void fullScreen() throws Exception {
+        // Example page using <l:layout type="full-screen">:
+        r.createWebClient().goTo("setupWizard/proxy-configuration");
+    }
+
 }