Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-57232] Add JCASC support #17

Merged
merged 4 commits into from
Nov 30, 2019
Merged

[JENKINS-57232] Add JCASC support #17

merged 4 commits into from
Nov 30, 2019

Conversation

PierreBtz
Copy link
Contributor

@reviewbybees

@PierreBtz PierreBtz self-assigned this Aug 4, 2019
@oleg-nenashev
Copy link
Member

CC jenkinsci/configuration-as-code-plugin#809

@PierreBtz
Copy link
Contributor Author

@jenkinsci/code-reviewers would somebody be available to give me a quick review over this. This is a big change and I'd like a second pair of eyes before merging. Thanks!

@oleg-nenashev oleg-nenashev self-requested a review October 6, 2019 16:09
alecharp
alecharp approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem on the PR but we could use more review on this.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/audit_trail/AuditLogger.java Show resolved Hide resolved
src/main/java/hudson/plugins/audit_trail/AuditLogger.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/audit_trail/AuditTrailFilter.java Show resolved Hide resolved
src/main/java/hudson/plugins/audit_trail/AuditTrailFilter.java Outdated Show resolved Hide resolved
src/test/resources/hudson/plugins/audit_trail/jcasc.yml Outdated Show resolved Hide resolved
@PierreBtz @alecharp
Apply suggestions from code review
dad66b9 
Co-Authored-By: Adrien Lecharpentier <[email protected]>
@oleg-nenashev oleg-nenashev requested a review from a team October 9, 2019 09:12
@oleg-nenashev
Copy link
Member

Just testing @jenkinsci/jcasc-compatibility-reviewers

@timja timja mentioned this pull request Oct 9, 2019
Merged
@PierreBtz PierreBtz force-pushed the pbeitz/JENKINS-57232 branch from fd6df62 to ab1980f Compare November 17, 2019 13:58
@PierreBtz
Copy link
Contributor Author

the force push was on the latest commit before it was reviewed, rest of the history that was reviewed remains untouched.

@PierreBtz PierreBtz mentioned this pull request Nov 18, 2019
Closed
@PierreBtz PierreBtz mentioned this pull request Nov 25, 2019
Closed
@PierreBtz PierreBtz merged commit f9c4678 into jenkinsci:master Nov 30, 2019
@PierreBtz PierreBtz deleted the pbeitz/JENKINS-57232 branch November 30, 2019 13:13
@PierreBtz PierreBtz mentioned this pull request Dec 1, 2019
Merged
pajikos pushed a commit to pajikos/audit-trail-plugin that referenced this pull request Jan 13, 2021
@PierreBtz
Merge pull request jenkinsci#17 from PierreBtz/pbeitz/JENKINS-57232
44520cd 
[JENKINS-57232] Add JCASC support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

@varyvol varyvol varyvol left review comments

@oleg-nenashev oleg-nenashev oleg-nenashev left review comments

@alecharp alecharp alecharp approved these changes

Assignees

@PierreBtz PierreBtz

Labels
breaking feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PierreBtz @oleg-nenashev @alecharp @varyvol @timja