Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build process on aarch64 machines #486

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Fix build process on aarch64 machines #486

merged 8 commits into from
Dec 20, 2024

Conversation

gounthar
Copy link
Collaborator

@gounthar gounthar commented Dec 19, 2024 •
edited
Loading

Fixes #476.
Fixes #487.

Update JdkFetcher.java to support aarch64 architecture.

  • Modify buildJDKFileName method to include architecture in the file name.
  • Add getArchitecture method to determine the system architecture.

Testing done

mvn install on x86_64 and aarch64.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar
Fix build process on aarch64 machines
d02e221 
Fixes #61

Update `JdkFetcher.java` to support aarch64 architecture.

* Modify `buildJDKFileName` method to include architecture in the file name.
* Add `getArchitecture` method to determine the system architecture.
* Update `CommandLineITCase.java` to handle architecture-specific JDK paths.
* Add `testBuildMetadataOnAarch64` method to verify the build process on aarch64 architecture.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/61?shareId=XXXX-XXXX-XXXX-XXXX).
@gounthar
fix(java): Adding arm64 as an alias for aarch64.
ba78813
@gounthar
fix(java): No need to add a specific method for aarch64.
3eaf58c
@gounthar
fix(java): Spotless apply
e2e0844
@gounthar
fix(java): Overly permissive file permission can lead to privilege es…
8f732b7 
…calation or information leakage.
@gounthar
fix(java): architecture appears only once in Adoptium's naming.
9e88812
@gounthar gounthar marked this pull request as ready for review December 19, 2024 21:49
@gounthar gounthar requested a review from jonesbusy as a code owner December 19, 2024 21:49
@jonesbusy jonesbusy added the bug For changelog: Minor bug. Will be listed after features label Dec 20, 2024
@jonesbusy jonesbusy merged commit e586f73 into jenkins-infra:main Dec 20, 2024
15 checks passed
@gounthar gounthar deleted the fix-aarch64-build branch December 26, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesbusy jonesbusy jonesbusy approved these changes

Assignees
No one assigned
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updatecli fails on gson-api update io.jenkins.tools.pluginmodernizer.cli.CommandLineITCase fails locally
2 participants
@gounthar @jonesbusy