Add Maven Invoker Integration Test and Ensure Successful Build #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that the CI pipeline is failing due to the MavenInvokerIntegrationTest. I am investigating the root cause and will push updates shortly. The test works locally, but it seems to encounter issues in the CI environment |
jonesbusy
reviewed
Dec 13, 2024
| import java.io.File; | ||
| import java.util.Arrays; | ||
|
|
||
| public class MavenInvokerIntegrationTest { |
There was a problem hiding this comment.
By default to be run by failsafe IT must match a certain pattern: https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html#inclusions
jonesbusy
reviewed
Dec 13, 2024
| public void testMavenGoalExecution() throws MavenInvocationException { | ||
| InvocationRequest request = new DefaultInvocationRequest(); | ||
| request.setPomFile(new File("pom.xml")); | ||
| request.setGoals(Arrays.asList("clean", "verify")); |
There was a problem hiding this comment.
We should run not run clean verify on the root pom
But invoke something like mvn exec:exec -Dexec.executable="java".....` by running the CLI previously build and packaged in a previous phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new integration test MavenInvokerIntegrationTest to validate Maven commands (clean and verify) using the Maven Invoker API.
Ensured the integration test runs successfully and verifies the build process.
Added the maven-invoker dependency to the plugin-modernizer-cli module for integration testing.
Updated the pom.xml in plugin-modernizer-cli to include required configurations for running tests.
Verified the project builds successfully with all tests passing.