Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests and configure failsafe , invoker plugins #450

Closed
wants to merge 0 commits into from

Conversation

SohamJuneja
Copy link
Contributor

This PR adds integration tests for the CLI using Maven Failsafe and Invoker plugins. The tests ensure that CLI commands, including --dry-run, work correctly after packaging, catching any classpath or packaging issues not covered by unit tests.

Key Changes:
Added integration tests in plugin-modernizer-cli/src/it/ to run the packaged CLI in dry-run mode.
Configured Failsafe plugin in plugin-modernizer-cli/pom.xml to execute the integration tests.
Configured Invoker plugin in the parent pom.xml to validate the entire project build.

@jonesbusy
Copy link
Collaborator

The --dry-run is not available anymore. So it's supposed to fail

In don't see any java test calling maven invoker here.

I think it would be preferable to implement java test calling maven invoker rather can created one pom.xml per test

Copy link
Collaborator

@jonesbusy jonesbusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment bellow

@SohamJuneja
Copy link
Contributor Author

Submitted a fresh PR with the changes you asked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants