-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #403 from SohamJuneja/patch-1
Add PR checklist template
- Loading branch information
Showing
1 changed file
with
27 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<!-- Please describe your pull request here. --> | ||
|
||
### Testing done | ||
|
||
<!-- Comment: | ||
Provide a clear description of how this change was tested. | ||
At minimum this should include proof that a computer has executed the changed lines. | ||
Ideally this should include an automated test or an explanation as to why this change has no tests. | ||
Note that automated test coverage is less than complete, so a successful PR build does not necessarily imply that a computer has executed the changed lines. | ||
If automated test coverage does not exist for the lines you are changing, you must describe the scenario(s) in which you manually tested the change. | ||
For frontend changes, include screenshots of the relevant page(s) before and after the change. | ||
For refactoring and code cleanup changes, exercise the code before and after the change and verify the behavior remains the same. | ||
--> | ||
|
||
### Submitter checklist | ||
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch! | ||
- [ ] Ensure that the pull request title represents the desired changelog entry | ||
- [ ] Please describe what you did | ||
- [ ] Link to relevant issues in GitHub or Jira | ||
- [ ] Link to relevant pull requests, esp. upstream and downstream changes | ||
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue | ||
|
||
<!-- | ||
Put an `x` into the [ ] to show you have filled the information. | ||
The template comes from https://github.com/jenkinsci/.github/blob/master/.github/pull_request_template.md | ||
You can override it by creating .github/pull_request_template.md in your own repository | ||
--> |