Implement Profile Switching (PoC) #6377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
|
|
I converted this to a draft since it is a proof of concept. Just a heads up, I’m currently pretty busy with life stuff so it might be awhile before I am able to review this, but this is definitely a feature we are interested in supporting. 💜 |
|
No problem. Do you have time to put together a list of requirements, or should I just use my best judgement (by copying much of how Android TV does it)? Oh, and a TL;DR of the PoC: Do you foresee any issues doing it this way (I can't think of anything)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LG's WebOS uses jellyfin-web for it's UI. This is a bit unfortunate because the jellyfin-web's UI/UX hasn't been as optimized for use on a TV. One of the biggest missing features that Android TV has that Web-OS does not is profile switching.
Warning: this code is just a crappy PoC that I hacked together really quickly.
After a user logs in their information and
accessTokenare stored inlocalStorage. I believe this is how the Android TV version does it (obviously not inlocalStorage, but in some other local db).big issues: Log out isn't handled right now, and there should be some settings toggles to enable/disable the feature.
For testing I just hacked this into the login page, and added some links to the login page to some menus. It's not pretty.
What work needs to be complete to getting something like this merged and shipped? I don't want to spend time polishing the UI/UX without some guidance/specs/requirements from the team.
Assuming you even want this feature in jellyfin-web at all, of course :-)
Issues
Fixes jellyfin/jellyfin-webos#168