Add support for the set functions from issue #597 #743
Conversation
rootart
force-pushed
the
issue/597
branch
2 times, most recently
from
988701b to
1a8870f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
========================================
+ Coverage 61.5% 63.3% +1.8%
========================================
Files 43 43
Lines 2786 3215 +429
Branches 161 244 +83
========================================
+ Hits 1713 2034 +321
- Misses 1060 1164 +104
- Partials 13 17 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
when returning a Set can we have the container type as well?
There was a problem hiding this comment.
Sure, I somehow missed that. I don't see a clear way how we can use generics or have better type support rather than Set[Any] for the results. Do you have other suggestions?
django_redis/client/default.py
Outdated
| if result is None: | ||
| return None | ||
| if isinstance(result, list): | ||
| return {self.decode(value) for value in result} | ||
| return self.decode(result) |
There was a problem hiding this comment.
could we have an utility method for this?
Co-authored-by: Ali Rezaei <[email protected]>
@WisdomPill I took over some work that was already done here #654. Will appreciate your support in reviewing it.