-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when using UUIDField as EAV2_PRIMARY_KEY_FIELD value #478
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
get_pk_format() always returns a valid value
for more information, see https://pre-commit.ci
@mathiasag7 - Can you rebase this? For example, the PR still has |
I see, but that doesn't help much. In fact, it return "Current branch master is up to date." |
Also, I want to bring to your attention that when you check the tests and run makemigrations, it will create a migration file, usually named 0012, which is correct. However, after verifying that the code works fine, please remember to remove this migration file. Failing to do so could lead to crashes when attempting to use a UUID as an ID. The issue arises because if the migration file sets the ID as an AutoField or a UUIDField, the user of the package cannot change it to the other type afterward. Therefore, the package needs to be flexible in this regard. Specifically, it should initially set the ID as a CharField. Then, when the user specifies their preference for the ID type, the package should automatically adjust it accordingly, removing the CharField. I hope this clarification is clear, let me know if not. |
You need to re-sync your fork at https://github.com/mathiasag7/django-eav2/tree/master For example, this file should not be there: https://github.com/mathiasag7/django-eav2/blob/master/eav/models.py |
Checklist
CHANGELOG.md
Pull Request type
Please check the type of change your PR introduces:
Related issue(s)
Format is: