feat: add option to change column size in a particular library #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yash-Garg
force-pushed
the
yg/library-columns
branch
from
d41b7cb to
4611d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to change column size inside a particular library.
However, I am still not sure how do we adapt it for the other landscape modes since we cannot use the dimensions directly in
AppPreferencesas a default value. Any input or feedback is appreciated.findroid/core/src/main/res/values-sw600dp/dimens.xml
Line 6 in a4499f5
findroid/core/src/main/res/values-sw720dp/dimens.xml
Line 4 in a4499f5
record.mp4