Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Quick Play #531

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feat: Quick Play #531

wants to merge 21 commits into from

Conversation

Natanel-Shitrit
Copy link
Contributor

@Natanel-Shitrit Natanel-Shitrit commented Sep 29, 2023 •
edited
Loading

Feature Preview

Home Fragment

screen-20230929-142958.2.mp4

TODO:

  • Implement in HomeFragment for "Continue Watching" / "Next Up".
  • Implement in HomeFragment for "Latest <Library Name>". (starts latest unwatched episode / starts movie)
  • Implement in ShowFragment for "Next Up".
  • Implement in ShowFragment for "Season" (starts latest unwatched episode).
  • Implement in SeasonFragment for episodes.
  • Implement in CollectionFragment for items.
  • Implement in DownloadsFragment for items.
  • Implement in FavoriteFragment for items.
  • Implement in SearchResultFragment for items.
  • Implement in LibraryFragment for items.
  • Add error popup when failing to play item.
  • Indicate to the user the item is loading somehow.

Related Issues

  • N/A

@Natanel-Shitrit Natanel-Shitrit marked this pull request as draft September 29, 2023 11:56
@Natanel-Shitrit Natanel-Shitrit marked this pull request as ready for review September 29, 2023 21:06
@Natanel-Shitrit
Copy link
Contributor Author

Ready for review :) @jarnedemeulemeester
Any ideas for the last 2 TODOs?

@Matix-Media
Copy link
Contributor

#531 (comment)

Any ideas for the last 2 TODOs?

Well, for the loading display, you could show a spinner in the middle of the clicked component, like for example, a spinner in the middle of the show banner like shown below
image

and for the error popup you could use a snackbar. Reference: https://m3.material.io/components/snackbar/overview

@Natanel-Shitrit Natanel-Shitrit changed the title WIP: feat: Quick Play feat: Quick Play Sep 29, 2023
@Natanel-Shitrit
Copy link
Contributor Author

#531 (comment)

Any ideas for the last 2 TODOs?

Well, for the loading display, you could show a spinner in the middle of the clicked component, like for example, a spinner in the middle of the show banner like shown below image

and for the error popup you could use a snackbar. Reference: https://m3.material.io/components/snackbar/overview

I've added a loading indicator, I just don't have a clue how to trigger it from the fragment 😄
I'll try to find a solution but help is much appreciated!

@Matix-Media
Copy link
Contributor

yeah got no clue either, sorry

@Natanel-Shitrit
Copy link
Contributor Author

I'm ditching the per-item loading, for now, it's just triggering the page loading indicator.
If anyone willing to help implement the per-item loading indicator feel free to contact me :)

@Natanel-Shitrit
Copy link
Contributor Author

Finally ready for review 😄
Added error snackbar!
image

@Natanel-Shitrit
Copy link
Contributor Author

RIP

@Natanel-Shitrit Natanel-Shitrit marked this pull request as draft December 30, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Natanel-Shitrit @Matix-Media