Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to disable broadcasting #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luisdalmolin
Copy link

Laravel has a new handy broadcastWhen method (https://laravel.com/docs/5.8/broadcasting#broadcast-conditions), which lets you control if you really want to broadcast even you are implementing the interface.

This PR implements this method and a config value, so you can disable broadcasting where you don't want.

@jakedowns
Copy link

+1 deleting mine, this would be awesome to see merged

@luisdalmolin
Copy link
Author

@jarektkaczyk Any chance we could get this one merged? Is not a breaking change in any way and it would be really helpful

@jakedowns
Copy link

jakedowns commented Mar 9, 2021

just chiming in to say that here in march 2021, this would still be helpful to have. i'm getting a The data content of this event exceeds the allowed maximum (10240 bytes) error for an event i don't even want to broadcast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants