Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationPolicy serviceAccount: allow same namespace #3417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howardjohn
Copy link
Member

This allows applying a policy like

apiVersion: security.istio.io/v1
kind: AuthorizationPolicy
metadata:
 name: allow-waypoint
spec:
  selector:
    matchLabels:
      app: echo
  action: ALLOW
  rules:
  - from:
    - source:
        serviceAccounts: ["waypoint"]

To get the semantics of "allow the waypoint in the same namespace".

It is common in k8s to allow configurations to be written without a namespace specified and have the namespace of references implied by the namespace it is eventually written to. This allows taking the same policy and applying it to many places without the need for modification/templating. As far as I know, this is allowed with virtually every k8s core type and Istio type today.

Note this just changes docs to match the implementation in istio/istio#54745 (which has a "hold" until this is approved)

Note: a release note is skipped since we have not shipped this feature

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Jan 17, 2025
@howardjohn howardjohn requested a review from a team as a code owner January 17, 2025 19:30
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2025
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm curious why I don't see any v1 changes generated?

@howardjohn
Copy link
Member Author

LGTM, but I'm curious why I don't see any v1 changes generated?

v1 is just type aliases. These are done struct level. This is changing a field within a struct, so there is no change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants