Bug fix in update selector func #152
Conversation
There was a problem hiding this comment.
I believe not all selector types with children are interchangeable. For example, children of elements and links are applied to different pages so they are not compatible.
Ideally, I'd suggest to implement update confirmation window for such cases, similar to one that pops up when deleting selector, with options to delete children or not
| @@ -156,9 +156,24 @@ export default class Sitemap { | |||
| // selector is undefined when creating a new one and delete old one, if it exist | |||
| if (selector === undefined || selector.type !== selectorData.type) { | |||
| if (selector) { | |||
| this.deleteSelector(selector); | |||
| if (selector.canHaveChildSelectors()) { | |||
There was a problem hiding this comment.
This retains children even if new type does not support them. You should check that selectorData (or both of them) can have children.
| //custom logic: we don’t delete children, but redefined them a parent | ||
| const children = this.selectors.filter(selectorFromList => | ||
| selectorFromList.parentSelectors.includes(selector.uuid) | ||
| ); | ||
| const newSelector = SelectorList.createSelector(selectorData); | ||
| children.forEach(child => { | ||
| const parentUuidIndex = child.parentSelectors.indexOf(selector.uuid); | ||
| child.parentSelectors[parentUuidIndex] = newSelector.uuid; | ||
| }); | ||
| selector = newSelector; |
There was a problem hiding this comment.
Similar logic is present below in // update child selectors section, maybe it is possible to simplify it. Also I'm not sure if it is even possible to receive different selector uids here when we update existing selector.
Bug fix for a situation when we change the selector type, but its children are removed even if the new selector type supports child selectors