Add Local Execution Mode Without Service #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it can be run locally without a service.
Yatskov
reviewed
Jul 29, 2024
Yatskov
reviewed
Jul 29, 2024
Yatskov
reviewed
Jul 29, 2024
Yatskov
reviewed
Jul 29, 2024
Yatskov
reviewed
Jul 29, 2024
scrapypuppeteer/middleware.py
Outdated
| ): | ||
| self.service_base_url = service_url | ||
| self.include_headers = include_headers | ||
| class ServiceBrowserManager(BrowserManager): |
There was a problem hiding this comment.
This should be moved to a seprate file.
Yatskov
reviewed
Jul 29, 2024
Yatskov
reviewed
Aug 6, 2024
setup.py
Outdated
|
|
||
| setup( | ||
| name="scrapy-puppeteer-client", | ||
| version="0.3.2", | ||
| version="0.3.1", |
There was a problem hiding this comment.
Upgrade version, not downgrade
Yatskov
reviewed
Aug 6, 2024
scrapypuppeteer/middleware.py
Outdated
| @@ -343,27 +199,19 @@ def from_crawler(cls, crawler: Crawler): | |||
| ) | |||
| return cls(recaptcha_solving, submit_selectors) | |||
|
|
|||
| @staticmethod | |||
Yatskov
reviewed
Aug 6, 2024
scrapypuppeteer/browser_manager.py
Outdated
| if puppeteer_request is None: | ||
| return response | ||
|
|
||
| if b"application/json" not in response.headers.get(b"Content-Type", b""): |
There was a problem hiding this comment.
This code looks specific for process response in service browser manager
Yatskov
reviewed
Aug 6, 2024
scrapypuppeteer/browser_manager.py
Outdated
|
|
||
|
|
||
|
|
||
| class ServiceBrowserManager(BrowserManager): |
There was a problem hiding this comment.
Split managers for diffrent files
Yatskov
reviewed
Aug 6, 2024
| @@ -72,18 +75,21 @@ def __init__( | |||
| service_url: str, | |||
| include_headers: Union[bool, List[str]], | |||
| include_meta: bool, | |||
| local_mode: bool, | |||
| browser_manager: Union[ServiceBrowserManager, LocalBrowserManager] | |||
Yatskov
reviewed
Aug 6, 2024
scrapypuppeteer/middleware.py
Outdated
| ): | ||
| self.service_base_url = service_url | ||
| self.include_headers = include_headers | ||
| self.include_meta = include_meta | ||
| self.crawler = crawler | ||
| self.used_contexts = defaultdict(set) | ||
| self.local_mode = local_mode |
Yatskov
reviewed
Aug 9, 2024
|
|
||
| from abc import ABC, abstractmethod | ||
|
|
||
| class BrowserManager(ABC): |
There was a problem hiding this comment.
Why not in browser_managers init.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add Local Execution Mode Without Service
Description
This update introduces a new local execution mode for the application, allowing it to run without relying on the external service. To enable this mode, the following setting needs to be configured:
Enable local execution mode
Additionally, for local execution, it is necessary to install Chromium for Pyppeteer.
Type of change
This change does not affect existing functionalities.