Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test #33

Merged
merged 18 commits into from
May 22, 2023
Merged

Add integration test #33

merged 18 commits into from
May 22, 2023

Conversation

vmordan
Copy link
Contributor

@vmordan vmordan commented May 18, 2023

Issue #25

@vmordan vmordan added the enhancement New feature or request label May 18, 2023
@vmordan vmordan requested review from PavelAndrianov and mutilin May 18, 2023 09:49
@vmordan vmordan self-assigned this May 18, 2023
@PavelAndrianov
Copy link
Contributor

Where is stage in CI for test run? In deploy?

@vmordan
Copy link
Contributor Author

vmordan commented May 18, 2023

Where is stage in CI for test run? In deploy?

Yes, we deploy scripts (as a launcher and witness visualizer) and then run integration tests

@vmordan vmordan force-pushed the add_integration_test branch 3 times, most recently from 4aa7e7f to 45871da Compare May 18, 2023 11:46
@vmordan vmordan force-pushed the add_integration_test branch from 45871da to bf6a41a Compare May 18, 2023 11:53
@PavelAndrianov
Copy link
Contributor

Yes, we deploy scripts (as a launcher and witness visualizer) and then run integration tests

Maybe, it is clearer to extract tests into a separate stage? Or it is difficult?

@vmordan
Copy link
Contributor Author

vmordan commented May 18, 2023

Maybe, it is clearer to extract tests into a separate stage? Or it is difficult?

We need build artifacts for tests (deploy directory with installed dependencies). Currently test itself requires about 10-15 seconds, whereas deployment requires about 20 minutes

@mutilin
Copy link
Contributor

mutilin commented May 18, 2023

Maybe, it is clearer to extract tests into a separate stage? Or it is difficult?

We need build artifacts for tests (deploy directory with installed dependencies). Currently test itself requires about 10-15 seconds, whereas deployment requires about 20 minutes

Can we reuse docker image from one stage to the other?

@PavelAndrianov
Copy link
Contributor

Can we reuse docker image from one stage to the other?

In gitlab CI we may reuse the previous stages. I do not known github, but, likely, there should be something like this.

Mordan Vitalii added 5 commits May 18, 2023 21:47
Add missing check for CIL path
3fb438f
Add missing YAML module dependency
56a55eb
Add option to ignore limitations for verification tasks
953c467 
BenchExec currently does not support cgroupv2 without workaround in kernel config,
thus we need an option to run tests without limitations.
Experiment with BenchExec options
0f41e3c
Fix names in reports paths
099b8fe
@vmordan vmordan merged commit eb186cb into master May 22, 2023
@vmordan vmordan deleted the add_integration_test branch June 1, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutilin mutilin mutilin approved these changes

@PavelAndrianov PavelAndrianov PavelAndrianov approved these changes

Assignees

@vmordan vmordan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmordan @PavelAndrianov @mutilin