Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use company locution service code instead of global service code #2849

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Use company locution service code instead of global service code #2849

merged 1 commit into from
Jan 8, 2025

Conversation

rbatistadev
Copy link
Contributor

Type Of Change

  • Small bug fix
  • New feature or enhancement
  • Breaking change

Checklist:

  • Commits are named and have tag following commit rules
  • Commits are split per component (schema, portal/platform, kamusers, agis, ..)
  • Changes have been tested locally
  • Fixes an existing issue (Fixes #XXXX)
  • Upport from existing Pull request #XXXX

Description

Additional information

@rbatistadev rbatistadev added +bug Bug portal/client Client portal *tempest* IvozProvider 4.x Tempest Release javascript labels Dec 30, 2024
@rbatistadev rbatistadev added this to the 4.3.0 milestone Dec 30, 2024
@rbatistadev rbatistadev self-assigned this Dec 30, 2024
ironArt3mis
ironArt3mis requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@ironArt3mis ironArt3mis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review required

@cruzccl cruzccl force-pushed the PROVIDER-2120-service-code-from-locution-is-not-used-correctly branch from 2c48cc3 to e26d26b Compare January 8, 2025 13:43
@cruzccl cruzccl changed the title Fixed locution services, retrieve from company Use company locution service code instead of global service code Jan 8, 2025
@cruzccl cruzccl force-pushed the PROVIDER-2120-service-code-from-locution-is-not-used-correctly branch from e26d26b to ded715a Compare January 8, 2025 13:57
@cruzccl cruzccl merged commit cc8d79c into bleeding Jan 8, 2025
5 checks passed
@cruzccl cruzccl deleted the PROVIDER-2120-service-code-from-locution-is-not-used-correctly branch January 8, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danigargar danigargar danigargar approved these changes

@ironArt3mis ironArt3mis ironArt3mis approved these changes

Assignees

@rbatistadev rbatistadev

Labels
+bug Bug functional-review javascript portal/client Client portal *tempest* IvozProvider 4.x Tempest Release
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rbatistadev @ironArt3mis @danigargar @cruzccl