Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dispatch] Two fixes for CollapseDimensionsPass #19598

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

IanWood1
Copy link
Contributor

@IanWood1 IanWood1 commented Jan 3, 2025

#19113 uncovered some problems with the logic in this pass.

Fixes two problems:

  1. If a consumer cannot be collapsed, producers can only collapse dimensions not touched by the consumer
  2. When updating which consumer loops can be collapsed, the reassociation of the producer must be taken into account since its possible they are not all contiguous (e.g. a transpose on an input). This is the same logic as in updateFromConsumer

@IanWood1 IanWood1 marked this pull request as ready for review January 3, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant