[LinalgExt] Scatter fusion by expansion 3/3 #19588
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update verifier to handle multiple batch dimensions for `updates` and
`indices`.
- Refine `ScatterOp` description to align with verifier behavior and
current usage.
- Previous description was outdated and inconsistent with verifier
logic.
- Restrict `dimension_map` to allow indexing only of the outermost
dimensions, ensuring slices are inserted contiguously.
- Add new helper methods to `ScatterOp` to facilitate extended
functionality.
- Update and add new test cases for `ScatterOp`:
- Remove tests involving non-contiguous slices.
- Add end-to-end tests for cases with more than one batch
dimension.
- Fix `TilingInterfaceImpl` to support multiple "batch" dimensions
and added test cases to `convert_to_loops.mlir` and `tiling.mlir`
Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
IanWood1
changed the title
Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the first 3 commits, they have their own PRs. See main issue #19091