Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add sensorring sensors within cob_hardware_config #359

Closed

Conversation

fmessmer
Copy link
Member

This is related to this discussion from https://github.com/ipa320/cob_common/pull/175

By adding the sensors like this, the original sensorring.urdf.xacro in cob_common (i.e. without sensor) can be used without any changes in cob_common (i.e. the sensorring_XXX.urdf.xacro could be removed again). In case another/additional sensor is mounted to the sensorring (or anywhere else on the robot), only the new file cob4-2.sensors.xacro needs to be modified (and of course according launch files in cob4-2.xml).

I'm open for discussion about how to name this file....maybe it could make sense to name it (non-sensor-related) e.g. cob4-2.[additons|aux|...].xacro. If we name it in a more general way, it might not necessarily be limited to sensors...but could be used for other components, too...
Doing it like that could also be applied to the other robots...i.e. raw3-1 has a lot of "attachements" added within raw3-1.urdf.xacro....by moving those into the additional file...the main file would look "cleaner"...

What do you think?
Agreement could be discussed on Monday!

@ipa-nhg
Copy link
Member

ipa-nhg commented Nov 13, 2015

I would like to define the whole robot together, for me a camera is a component , like an actuator,

My suggestion was define a new level between robot and component: modules. And also define a default configuration for each module. The robots bringup should use (as links) the default configuration of each module. Because also ,at the moment, I have the problem that if I create a new robot I have to COPY all the configuration files , and if we modify a feature we have to adapt the configuration files for all the robots.

I tried to create a tree structure of my idea:

screenshot from 2015-11-13 11 44 36

@ipa320 ipa320 locked and limited conversation to collaborators Nov 20, 2015
@fmessmer
Copy link
Member Author

Let's keep this locked and unmerged until we discussed how to simplify the configuration structure during one of our next orga sessions....

@fmessmer fmessmer changed the title add sensorring sensors within cob_hardware_config [WIP] add sensorring sensors within cob_hardware_config Nov 20, 2015
@ipa320 ipa320 unlocked this conversation Feb 19, 2016
@fmessmer
Copy link
Member Author

closing in favor of issue #437

@fmessmer fmessmer closed this Feb 19, 2016
@fmessmer fmessmer deleted the feature_sensorring_sensors branch February 19, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants