[WIP] add sensorring sensors within cob_hardware_config #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to this discussion from https://github.com/ipa320/cob_common/pull/175
By adding the sensors like this, the original sensorring.urdf.xacro in cob_common (i.e. without sensor) can be used without any changes in cob_common (i.e. the sensorring_XXX.urdf.xacro could be removed again). In case another/additional sensor is mounted to the sensorring (or anywhere else on the robot), only the new file
cob4-2.sensors.xacro
needs to be modified (and of course according launch files in cob4-2.xml).I'm open for discussion about how to name this file....maybe it could make sense to name it (non-sensor-related) e.g. cob4-2.[additons|aux|...].xacro. If we name it in a more general way, it might not necessarily be limited to sensors...but could be used for other components, too...
Doing it like that could also be applied to the other robots...i.e. raw3-1 has a lot of "attachements" added within raw3-1.urdf.xacro....by moving those into the additional file...the main file would look "cleaner"...
What do you think?
Agreement could be discussed on Monday!