remove nav config for unsupported bases #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgruhler
approved these changes
Apr 12, 2017
| find_package(cob_default_env_config REQUIRED) | ||
| find_package(roslaunch REQUIRED) | ||
| foreach(robot ${cob_supported_robots_ROBOTLIST}) |
There was a problem hiding this comment.
why do you no longer use cob_supported_robots?
There was a problem hiding this comment.
because cob_supported_robots supports cob4-3, cob4-4 and cob4-6 which we do not support nav-configs for...
There was a problem hiding this comment.
does it make sense to have another macro in cob_supported_robots about navigation (and manipulation or perception) capabilities?
There was a problem hiding this comment.
don't think so...for the time being this approach is sufficient, I guess...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ipa320/cob_robots#437
related to ipa320/cob_robots#654