Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(range): add focus styles to range #30077

Merged
merged 6 commits into from
Dec 13, 2024
Merged

feat(range): add focus styles to range #30077

merged 6 commits into from
Dec 13, 2024

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Dec 11, 2024 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Add focus styles to ion-range when using Ionic theme.
  • Add new focus test for ionic theme.
  • Add new snapshots.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Dec 11, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 7:20pm

@BenOsodrac BenOsodrac requested a review from thetaPC December 11, 2024 12:23
@BenOsodrac BenOsodrac removed the request for review from thetaPC December 11, 2024 13:15
@BenOsodrac BenOsodrac requested a review from thetaPC December 11, 2024 13:33
@BenOsodrac BenOsodrac marked this pull request as ready for review December 11, 2024 13:33
@BenOsodrac BenOsodrac requested a review from a team as a code owner December 11, 2024 13:33
thetaPC
thetaPC requested changes Dec 12, 2024
View reviewed changes
core/src/components/range/test/states/range.e2e.ts Outdated Show resolved Hide resolved
core/src/components/range/test/states/range.e2e.ts Outdated Show resolved Hide resolved
core/src/components/range/test/states/range.e2e.ts Outdated Show resolved Hide resolved
@BenOsodrac BenOsodrac requested a review from thetaPC December 12, 2024 19:28
thetaPC
thetaPC approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit 3091390 into next Dec 13, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11445-range branch December 13, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenOsodrac @brandyscarney @thetaPC @Ionitron