Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pull-requests): enforce conventional commits #29438

Merged
merged 5 commits into from
May 1, 2024
Merged

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented May 1, 2024

Issue number: N/A


What is the current behavior?

Framework has a structure when it comes to PR titles. However, there aren't any reinforcements to it unless a reviewer checks it.

What is the new behavior?

  • Added a GitHub action that will validate the PR title. It checks that there is a valid type, checks that it has a scope, and that the subject doesn't start with a uppercase character.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Create a branch from this one to test it out.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 6:47pm

@thetaPC thetaPC changed the title feat(pull-requests): enforce conventional commits feat(pull-requests): Use capital word May 1, 2024
@thetaPC thetaPC changed the title feat(pull-requests): Use capital word feat(pull-requests): enforce conventional commits May 1, 2024
@thetaPC thetaPC marked this pull request as ready for review May 1, 2024 19:28
@thetaPC thetaPC requested a review from a team as a code owner May 1, 2024 19:28
@thetaPC thetaPC requested a review from sean-perkins May 1, 2024 19:28
@sean-perkins
Copy link
Contributor

Great work with this process improvement!

@sean-perkins sean-perkins changed the title feat(pull-requests): enforce conventional commits chore(pull-requests): enforce conventional commits May 1, 2024
@thetaPC thetaPC added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 78a6105 May 1, 2024
50 checks passed
@thetaPC thetaPC deleted the conventional-commits branch May 1, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants