Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Lucid vesting app. #127

Open
wants to merge 1 commit into
base: fourth-iteration
Choose a base branch
from

Conversation

nkarl
Copy link

@nkarl nkarl commented Nov 18, 2024

In this PR, I did the following:

  1. Update the dependencies of the Lucid vesting app.
    • Updated lucid-cardano to version 0.10.10 since previous version breaks with security concern.
    • Updated Webpack config so that students should use a local .env file to set their own Blockfrost project Id for this app. Added a README to instruct students on this step.
  2. Removed and refactored unneeded files and logic.
    • Removed the static bootstrap CSS file because it can now be pulled as a dependency.
    • Removed the date-time-picker because it is natively supported by modern browsers via datetime-local.
    • Refactored the logic of the app; separated many actions for better clarity (single responsibility).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant