Skip to content

Commit

Permalink
CI fixes
Browse files Browse the repository at this point in the history
Correct definition of matrix job with override values
  • Loading branch information
blaskoa committed Jan 25, 2024
1 parent a1082bf commit 9e6c923
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ on:
jobs:
package-lint:
runs-on: ubuntu-latest
strategy:
matrix:
variant-values: ['ci-multitenant-values.yaml', 'ci-edge-values.yaml']
steps:
- uses: actions/checkout@v3
- name: Setup helm CLI
Expand All @@ -36,6 +33,9 @@ jobs:
- uses: pre-commit/[email protected]
test-cluster:
runs-on: ubuntu-latest
strategy:
matrix:
variant-values: ['ci/multitenant-values.yaml', 'ci/edge-values.yaml']
steps:
- uses: actions/checkout@v3
- name: Setup helm CLI
Expand Down Expand Up @@ -70,7 +70,7 @@ jobs:
TENANT_1_SECRET: ${{ secrets.TENANT_1_SECRET }}
TENANT_2_SECRET: ${{ secrets.TENANT_2_SECRET }}
run: |
helm install smartface . -f ci-values.yaml --set tests.authentication.tenant1.clientSecret="$TENANT_1_SECRET" --set tests.authentication.tenant2.clientSecret="$TENANT_2_SECRET" -f ${{ matrix.variant-values }}
helm install smartface . -f ci/test-values.yaml --set tests.authentication.tenant1.clientSecret="$TENANT_1_SECRET" --set tests.authentication.tenant2.clientSecret="$TENANT_2_SECRET" -f ${{ matrix.variant-values }}
kubectl rollout status deployment sf-api --timeout=300s
kubectl wait --for=condition=complete job/sf-wl-update-log-population --timeout=300s
- name: Test helm chart
Expand Down
3 changes: 3 additions & 0 deletions ci/edge-values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
features:
edgeStreams:
enabled: true
3 changes: 3 additions & 0 deletions ci/multitenant-values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
features:
multitenancy:
enabled: true
5 changes: 0 additions & 5 deletions ci-values.yaml → ci/test-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@ minio:
persistence:
enabled: false

# We enabled edge streams so we can run all of the tests in one go with all features enabled
features:
edgeStreams:
enabled: true

configurations:
apiAuth:
authority: "https://smartface-test.eu.auth0.com"
Expand Down

0 comments on commit 9e6c923

Please sign in to comment.