Add StdGems check #130
Open
Add StdGems check #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: #616
Aim
Register StdGemsCheck hook with overcommit.
Other
Looking at the overcommit source code, it seems Git tracking status of the hook file is considered when calcualting hook signature. Since hook files (eg. zeitwerk check) aren't tracked at the moment template is being applied to the new Rails app, it means the signature will be different(wrong) later when overcommit runs the pre-commit/push hooks. The solution, track hook files, prior to signing them.
TODO
std_gemson RubyGems and update Gemfile reference