Fix: page.resolve.then
inline promise never resolving
#2135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
<WhenVisible>
component is used withpreserveUrl: true
the promise inpage.resolve
never actually resolves since history isn't being replaced and the callback is never called.Example:
This will get stuck forever and never resolve.
This PR adjusts
page.set
when it returnspage.resolve.then
so that the promises it creates resolve without depending on the callback ifpreserveUrl
is set to true. The callback is still used ifpreserveUrl
is false, since the callback is queued normally in that scenario.