Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and simplify plugin structure #267

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

pfefferle
Copy link
Member

No description provided.

@pfefferle pfefferle requested review from dshanske and a team November 29, 2024 07:43
Copy link
Member

@dshanske dshanske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of SASS means the rebuild process for the icons is not scripted. The build icons script doesn't generate the final css file.

Probably could come up with a non Grunt solution though.

@pfefferle
Copy link
Member Author

pfefferle commented Nov 29, 2024

Oooos! I will add an npm task instead! Good catch!

@dshanske
Copy link
Member

That build process is something I have thought of redoing. SinpleIcons has gotten a lot larger since I picked it and maybe I should be doing a subset.

Just curation is a pain.

@dshanske
Copy link
Member

dshanske commented Dec 7, 2024

I was thinking about this. I could add sass as a script and dependency to the package.json file and run it that way. Will test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants