Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tagging support #4

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

adding tagging support #4

wants to merge 12 commits into from

Conversation

dissolve
Copy link
Member

@dissolve dissolve commented Dec 3, 2014

works for my test case
should not interfere with any current usage

@@ -113,6 +114,59 @@ function parse($mf, $refURL=false, $maxTextLength=150, $maxLines=2) {
}
}
}
// If the post has an explicit tag-of property, verify it matches $refURL and set the type to "reply"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean set the type to "tag", correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes "tag". my bad

@aaronpk
Copy link
Member

aaronpk commented Sep 16, 2016

Do you have any tests or documentation for this? It would be great if you added something to the readme showing examples of what the changes do, as well as adding tests for the new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants