Give the pom and eclipse feature the same name. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the pom.xml tells maven this artifact is called "org.eclipse.imp.imp.runtime.feature" (due to the groupId) and the feature.xml tells Tycho that this artifact is called "imp.runtime.feature". I couldn't figure out how to actually get an updatesite to successfully build with this as it is.
This patch changes both to agree on the name "org.eclipse.imp.runtime.feature".
I scanned through: https://github.com/search?q=%22imp.runtime.feature%22&type=Code&utf8=%E2%9C%93
It looks like the impacted projects as a result of this change would be the Rascal updatesite and feature:
https://github.com/cwi-swat/rascal-feature (feature.xml)
https://github.com/cwi-swat/rascal-update-site (category.xml and pom.xml)
Those would need references to this feature updated.
I'm still a little bit baffled that this works for you guys as-is. I couldn't get it to. This change fixes things for me, so I thought the issue was that Tycho was unable to find the Maven artifact because of the differing names. But if it works for you... maybe I'm also doing something else weird?