Allow GameScale to be adjusted in-game using controller/keyboard #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MachEnergy
reviewed
Dec 22, 2023
InGame/Overlay/OverlayManager.cs
Outdated
| @@ -457,6 +470,16 @@ private void SetState(MenuState newState) | |||
| _currentMenuState = newState; | |||
| } | |||
|
|
|||
| private static void HandleGameScaleChanged(GameScaleDirection scaleDirection) | |||
There was a problem hiding this comment.
There are no other methods with naming convention "Handle...". Suggest renaming to match legacy author's conventions and leave "Handle..." for future event handlers, if needed.
There was a problem hiding this comment.
Good suggestion. Updated here: 7194ce9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to modify the game scale in-game via the keyboard/controller.
Keys default to L/R buttons on controller, +/- buttons on keyboard.
Inspired from a Vinesauce stream, where Vinny mentioned it should be added in an update.
Items of note
It looks like at some point L/R were intended to be used for something, but were commented out of the code.
Additionally, I've had to adjust the margins of the Control Settings screen in order to fit the new key rows. This is less noticeable in the in-game Settings menu - however, in the Settings menu found at the Main Menu the "Reset" and "Back" buttons were being pushed off screen by the two new button rows.
Future Improvements
Having some kind of toast or UI indication appear on screen when a player adjusts the scale would be nice.
Screenshots
Control Settings (Main Menu)
Control Settings (In-Game)
In-Game Footage
Link.s.Awakening.-.In-Game.Scale.mp4